feat(realtime): add presence enabled flag on join payload #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add enabled field to RealtimeChannelPresenceConfig type - Add _has_callback_attached property to AsyncRealtimePresence - Set presence.enabled based on callback attachment or manual config - Add automatic resubscription when presence callbacks are added to joined channel - Add comprehensive tests for new functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix AttributeError by mocking _ws_connection instead of trying to set is_connected property - Ensure test properly mocks socket connection for presence enabled flag validation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
grdsdev
commented
Sep 25, 2025
| logger.info( | ||
| f"channel {self.topic} resubscribe due to change in presence callbacks on joined channel" | ||
| ) | ||
| asyncio.create_task(self._resubscribe()) |
There was a problem hiding this comment.
@o-santi not sure if this create_task is appropriate here, should I hold a reference for the task to make sure it is finished/cancelled?
There was a problem hiding this comment.
Well, we can hold a reference but there's no real way to make sure its finished without randomly throwing errors, as we cannot raise something out of thin air.
If we really want to make sure it's finished, we should spawn a local loop and run it in there ... which is finicky. By the nature of unsubscribe and subscribe, we are not sure that we've got any state change, as the only thing those two functions do is send the message.
In order to properly handle this, these functions should've been async in the first place, but that can only be changed in the V3.
o-santi
approved these changes
Sep 26, 2025
grdsdev
deleted the
guilherme/clibs-218-realtime-py-add-presence-enabled-flag-on-join-payload
branch
grdsdev
added a commit
to supabase/supabase
that referenced
this pull request
Sep 30, 2025
Update documentation to reflect the automatic presence enablement behavior introduced in supabase-py PR #1229. Presence is now automatically enabled when presence callbacks are attached to a channel. Changes: - Updated subscribe() method notes in supabase_py_v2.yml - Added note about automatic presence enablement when callbacks are attached - Documented automatic resubscription behavior when callbacks are added post-join - Maintains existing documentation structure and formatting Source: supabase/supabase-py#1229 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
enabledfield toRealtimeChannelPresenceConfigtype definition_has_callback_attachedproperty toAsyncRealtimePresenceclass to detect if any presence callbacks are registeredpresence.enabled=truewhen presence callbacks are attached or manually configuredTest plan
_has_callback_attachedpropertyenabledfieldpresence.enabledflag setting🤖 Generated with Claude Code